BIM – tidy up #2

Some more tidying up of BIM to get it ready for release.

Error messages on student details

When one student views the details, we’re getting error messages.

Okay, need another check. That’s done.

Check the group usage

Have got the allocate groups stuff working, is it actually being used by the support functions that return lists of students associated with markers?

No.

So, the get_records_select for the tmp table bim_markers_students needs to get replaced with something that goes via bim_group_allocation and then group_members to get the userids.

That means changing the signature of the bim_get_markers_students function – take bim now, not course. My, the comments actually said course was temporary.

Update the calls to records select to go via the other tables.

Done.

Fix up the display of last post in the student details screen

This is a hang over of the change from datetime in BAM to unix timestamps in Moodle. There are at least 2 contributing problems to this :

  • Test data from BAM into BIM put in just a year, not the unixtime.
    So need to modify the lastpost entry in my test bim_student_feeds to be using unixtime. All entries changed to the same value.
  • The display of the timestamp in BIM isn’t doing the right conversion.
    Already doing this in the allocation and marking form using the PHP date function. Done.

Ahh, but that’s the rub. What is actually needed here is how long ago the last post was. That’s a different method.

Used function from here to implement.

Removed sortable links on tables

Haven’t groked how to do the flexible_table sorting. Will leave that for later.

Leave a Reply

Please log in using one of these methods to post your comment:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out /  Change )

Google photo

You are commenting using your Google account. Log Out /  Change )

Twitter picture

You are commenting using your Twitter account. Log Out /  Change )

Facebook photo

You are commenting using your Facebook account. Log Out /  Change )

Connecting to %s